Add missing entries for '7sus4', 'add11', 'add13', 'add9' to chord_shorthand #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orthand Typo: replace dictionairy with dictionary
|
Nice work |
|
I think 11 and add11 are different: add11 has an added 11th without the 7th and 9th |
Exactly, those chords imply different notes. That difference is necessary for the robustness of modern harmony |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A call like
from_shorthand('C7sus4')resulted in an "Unknown shorthand" error. I noticed that some other entries inchord_shorthand_meaningwere not present inchord_shorthandso I added these as well.To run
make testI had to install numpy.The following call still results in an error, but I don't know the code well enough to make it work:
from_shorthand('C9b5')